rony-chat-bot/internal/embed/embed.go
Victor Hugo Vargas 129809067b feat(rag): hybrid retrieval, reference documents, and vendor sampling
Answers were short, sometimes in the wrong language, and occasionally about
projects that do not exist. Measured on a 20-question battery against the real
corpus in both Spanish and English, this takes grounded content from 3/10 to
9/10 and language matching from 7/10 to 10/10.

Retrieval
- Fuse FTS5 keyword search with dense vectors via Reciprocal Rank Fusion.
  Both halves are load-bearing: the corpus is English and visitors ask in
  Spanish, so the meaningful words score zero. "paga" appears 0 times in a
  document that says "Payments: Stripe" — the question "¿Con qué se paga en la
  tienda de ropa?" retrieved nothing at all. Embeddings put all three of that
  project's chunks on top. RRF ranks by agreement rather than comparing a BM25
  score against a cosine, quantities with no shared scale.
- internal/embed: OpenAI-compatible embeddings client, unit-normalised so a
  dot product is the cosine. Reorders by the response `index` field.
- Store a content hash beside each vector and skip rows where it no longer
  matches the chunk. Chunk ids survive body edits, so without this an edited
  document keeps serving embeddings that describe text that is gone —
  reproduced live by changing a payment provider and watching the old one keep
  coming back.
- Degrade to keyword-only when the embedder is down instead of failing.

Reference documents that are not projects
- Index `.mdx` alongside `.md`, and split sources into projects (announced in
  the catalogue) and reference material (retrievable, never listed). A CV is
  what someone deciding whether to hire actually reads, and it was unreachable
  while it lived only in the Astro site — but filing it under projects made
  the bot list "cv" as one of Victor's works.
- Skip each directory's README. `data/projects/README.md` was being indexed,
  so the catalogue injected into every prompt announced "README" and
  "README.es" as projects of Victor's.
- Exclude frontmatter from retrieval. It is dense metadata in a very short
  chunk, which makes it a magnet for short queries: a CV's `location:` field
  answered "¿Dónde ha trabajado Victor?" with a city instead of a work history.
- Split oversized sections at `###` before falling back to byte offsets. A CV's
  Experience section is a list of jobs, and size-splitting cut one mid-word,
  stranding the employer's name in the previous chunk.

Prompt and sampling
- Inject the full project catalogue every turn. Top-K search returns the best
  matching sections, so "list every project" cannot be answered from retrieval
  alone, and a small model asked to enumerate from partial hits invents the
  rest. ~10 tokens per project; this is what stopped the invented names.
- Wire the sampling parameters the model authors publish (top_k, top_p, min_p,
  repeat_penalty, presence_penalty) through config to llama.cpp. Leaving them
  at llama.cpp's defaults produced 16-token stub answers.
- Localised system prompt selected by detected language. The English prompt
  plus "reply in the user's language" answered 1/5 Spanish questions in
  Spanish; few-shot examples fixed the language but got copied verbatim into
  real answers.
- Fold compaction's system notes into the leading system message. Gemma's chat
  template rejects a system message that is not first, and the whole request
  failed with HTTP 400 the moment compaction fired.

Configuration and docs
- context_size 4096, down from 8192. The largest prompt this bot ever built
  over 20 real requests was 1255 tokens, compaction starts at ~3070, and the
  cut saved 212 MB resident with zero truncations and identical throughput.
- Correct the RAM figures throughout. They were measured with a GPU absorbing
  llama.cpp's buffers; on a GPU-less VPS those come out of system RAM, which
  is 1.1 GB more for qwen2.5-3b and 2.8 GB more for granite. Both READMEs
  still started gemma-3-1b while the config defaulted to qwen, and neither
  started the embedder at all.

Measured on the 2-core, 8 GB CPU-only target: 3.64 GB LLM + 0.91 GB embedder
+ 0.02 GB bot, 21.0 tok/s steady state.

Known and unfixed, so they are not re-filed as new bugs: the model reads dates
out of the CV correctly but does the arithmetic on them wrong, and "¿Dónde ha
trabajado Victor?" still answers with projects rather than employers, though
"¿En qué empresas ha trabajado?" works.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-07-30 15:45:36 -07:00

186 lines
5.2 KiB
Go

// Package embed talks to an OpenAI-compatible /v1/embeddings endpoint
// (llama-server --embedding) and provides the vector maths the RAG store
// needs.
//
// Why this exists: the SQLite FTS5 index matches words exactly. Visitors ask
// in Spanish about a portfolio written in English, so the terms that carry the
// meaning — "paga", "trabajado" — appear zero times in the corpus, which says
// "Payments: Stripe" and "worked". Measured on the real corpus, keyword search
// returned nothing at all for "¿Con qué se paga en la tienda de ropa?" while a
// multilingual embedding put all three tienda-ropa chunks on top. Keyword
// search still wins on exact proper nouns, so the store keeps both and fuses
// them.
package embed
import (
"bytes"
"context"
"encoding/binary"
"encoding/json"
"fmt"
"io"
"math"
"net/http"
"time"
)
// Config describes the embedding endpoint.
type Config struct {
BaseURL string // e.g. http://localhost:9200/v1
Model string // sent as "model"; llama-server ignores it
BatchSize int // texts per request (0 → 8)
TimeoutMS int // per-request timeout (0 → 120s)
}
// Client is a minimal embeddings client.
type Client struct {
baseURL string
model string
batchSize int
http *http.Client
}
func New(cfg Config) *Client {
batch := cfg.BatchSize
if batch <= 0 {
batch = 8
}
timeout := time.Duration(cfg.TimeoutMS) * time.Millisecond
if timeout <= 0 {
timeout = 120 * time.Second
}
return &Client{
baseURL: cfg.BaseURL,
model: cfg.Model,
batchSize: batch,
http: &http.Client{Timeout: timeout},
}
}
type embedRequest struct {
Model string `json:"model,omitempty"`
Input []string `json:"input"`
}
type embedResponse struct {
Data []struct {
Index int `json:"index"`
Embedding []float32 `json:"embedding"`
} `json:"data"`
}
// Embed returns one unit-length vector per input, in input order.
//
// Vectors are normalised here, once, so similarity at query time is a plain
// dot product instead of a cosine with two square roots per candidate.
func (c *Client) Embed(ctx context.Context, texts []string) ([][]float32, error) {
out := make([][]float32, 0, len(texts))
for start := 0; start < len(texts); start += c.batchSize {
end := min(start+c.batchSize, len(texts))
vecs, err := c.embedBatch(ctx, texts[start:end])
if err != nil {
return nil, err
}
out = append(out, vecs...)
}
return out, nil
}
func (c *Client) embedBatch(ctx context.Context, texts []string) ([][]float32, error) {
body, err := json.Marshal(embedRequest{Model: c.model, Input: texts})
if err != nil {
return nil, err
}
req, err := http.NewRequestWithContext(ctx, http.MethodPost, c.baseURL+"/embeddings", bytes.NewReader(body))
if err != nil {
return nil, err
}
req.Header.Set("Content-Type", "application/json")
resp, err := c.http.Do(req)
if err != nil {
return nil, fmt.Errorf("embeddings request: %w", err)
}
defer resp.Body.Close()
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
msg, _ := io.ReadAll(resp.Body)
return nil, fmt.Errorf("embeddings API %d: %s", resp.StatusCode, string(msg))
}
var parsed embedResponse
if err := json.NewDecoder(resp.Body).Decode(&parsed); err != nil {
return nil, fmt.Errorf("decode embeddings: %w", err)
}
if len(parsed.Data) != len(texts) {
return nil, fmt.Errorf("embeddings returned %d vectors for %d inputs", len(parsed.Data), len(texts))
}
// The API documents an `index` field rather than guaranteeing order.
out := make([][]float32, len(texts))
for _, d := range parsed.Data {
if d.Index < 0 || d.Index >= len(out) {
return nil, fmt.Errorf("embeddings returned out-of-range index %d", d.Index)
}
out[d.Index] = Normalize(d.Embedding)
}
for i, v := range out {
if v == nil {
return nil, fmt.Errorf("embeddings response missing index %d", i)
}
}
return out, nil
}
// Normalize scales v to unit length. A zero vector is returned unchanged —
// dividing by zero would poison every later comparison with NaN.
func Normalize(v []float32) []float32 {
var sum float64
for _, x := range v {
sum += float64(x) * float64(x)
}
if sum == 0 {
return v
}
inv := float32(1 / math.Sqrt(sum))
out := make([]float32, len(v))
for i, x := range v {
out[i] = x * inv
}
return out
}
// Similarity is the dot product, which equals cosine similarity for the
// unit-length vectors this package produces. Mismatched lengths score 0 so a
// stale row from a different embedding model can never outrank a real hit.
func Similarity(a, b []float32) float64 {
if len(a) != len(b) || len(a) == 0 {
return 0
}
var sum float64
for i := range a {
sum += float64(a[i]) * float64(b[i])
}
return sum
}
// Encode serialises a vector as little-endian float32 for a SQLite BLOB.
func Encode(v []float32) []byte {
buf := make([]byte, 4*len(v))
for i, x := range v {
binary.LittleEndian.PutUint32(buf[4*i:], math.Float32bits(x))
}
return buf
}
// Decode reverses Encode. A blob whose length isn't a multiple of 4 is
// corrupt and yields nil rather than a truncated vector.
func Decode(b []byte) []float32 {
if len(b)%4 != 0 {
return nil
}
out := make([]float32, len(b)/4)
for i := range out {
out[i] = math.Float32frombits(binary.LittleEndian.Uint32(b[4*i:]))
}
return out
}